Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While parsing the CGMI of my device (SIM7020), I've noticed that I was getting a lot of parsing errors.
After digging deeper, I've discovered that the parsing errors were actually
EofWhileParsingString
errors.Finally, I've discovered why: my manufacturer string looked like this:
And this was breaking at the
_
, because it's not considered alphanumeric.My fix here is to allow all ASCII characters >= 32 (space + printable characters).
The only non-printable character included is
DEL
(127) - but it shouldn't be a big deal.Before my fix:
After my fix: