Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add alloc feature to serde_at to enable alloc::string::String parsing #192

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

dragonnn
Copy link
Contributor

@dragonnn dragonnn commented Dec 8, 2023

When using alloc on embedded String can be used through alloc::string::String. This PR adds support for alloc to serde_at and when the feature is enabled it enables parsing deserialize_string by using directly deserialize_str with does seam to work perfectly fine in my tests.

Copy link
Member

@MathiasKoch MathiasKoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thank you!

@MathiasKoch MathiasKoch merged commit 23d9c18 into FactbirdHQ:master Dec 11, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants