Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto update meta about new fapi versions #1249

Closed
wants to merge 3 commits into from

Conversation

dexman545
Copy link
Contributor

@dexman545 dexman545 commented Jan 1, 2021

Companion to FabricMC/fabric-meta#10

When a release is built, adds the API version to the list of MC versions based on the MC version it was built against.

@i509VCB i509VCB requested review from modmuss50 and a team January 19, 2021 21:10
@i509VCB i509VCB added the priority:low Low priority PRs that don't immediately need to be resolved label Jan 19, 2021
build.gradle Show resolved Hide resolved
@dexman545
Copy link
Contributor Author

I've made it use grgit now (which was already in use by the script) didn't know how to specify user by git command line without fear of screwing things up.

If the modules included an MC deps with version ranges, I could make it a bit better with generating MC versions, but would mean bringing in a semver parser to the script. Just having built-against MC version would be a big step up.

@liach liach requested a review from a team June 2, 2021 11:31
@liach
Copy link
Contributor

liach commented Jun 2, 2021

@modmuss50 @sfPlayer1 Is this concept acceptable? If the overall direction is wrong, halting this than letting this go nowhere would be better.

@liach liach added the enhancement New feature or request label Jun 2, 2021
@modmuss50
Copy link
Member

This not how I would go about doing this, and something we decided to put on hold.

@modmuss50 modmuss50 closed this Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:low Low priority PRs that don't immediately need to be resolved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants