Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#40 add custom text color for contribution #41

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

FabDonRixos
Copy link
Owner

@FabDonRixos FabDonRixos commented Nov 26, 2024

Description

I have added a custom text color attribut so its variable and won't be unreadable in some situations.

Used issue #40

Type of change

  • New Component (non-breaking change which adds functionality to the website)
  • New Feature (non-breaking change which adds a new css component)
  • Bug fix (non-breaking change which fixes a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project.
  • I have updated my code state to the newest version.
  • I have performed a self-review of my code.
  • My code is properly structured and easy to read for others.
  • If something could be unclear/complex for others to understand I have made a comment for this part.
  • My changes generate no new warnings or errors inside the console.
  • It's easy to see what issue was used for these changes.
  • I have only used module css classes, with exception for some part where you can use the index.scss.
  • I have read the CODE OF CONDUCT & the CONTRIBUTING.

Components specific

  • The Component is somewhere unique to already other created components.
  • I have only used html and css to create my component, apart from the React component.
  • I have made the whole component myself and didn't steal it from someone other.
  • I have documented my own copyright statements inside the artwork List.

Feature specific

  • My new Feature does not affect the styling and the functioning of other thing, in a way, so they don't work
    anymore.
  • If I edited some core files of the project I have checked the code extra carefully.
  • If the new feature have UI changes, I have made them responsive as good as possible.

@FabDonRixos FabDonRixos merged commit f45caae into master Nov 26, 2024
1 check passed
@FabDonRixos FabDonRixos deleted the feature/#40-Custom-Text-Color branch November 26, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant