Compensations for hardware testing #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Might be a bit jerky from what I see. I'll have to think of something to fix that if it is. |
|
It is a tad jerky (you can find video of it on Discord.) Best fix might be to just use a current ramp on the motor? |
This reverts commit 9d7b107.
Dunno how well this will work at all points...
c-x-berger
commented
Feb 17, 2019
| @@ -25,7 +25,7 @@ | |||
| // public static final int rangefinderModule = 1; | |||
|
|
|||
| public class DRIVETRAIN { | |||
| public static final int LEFT_MASTER_CHANNEL = 0; | |||
| public static final int LEFT_MASTER_CHANNEL = 17; | |||
There was a problem hiding this comment.
c-x-berger
changed the title
|
Leaving WIP status because we're about to wire the practice bot and make a whole new slew of these changes. (Merging once Travis agrees that things look good.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also #12. This PR is for any changes made as a direct result of real-world testing of components.
This is being added to DEEP SPACE and the stop build milestone as a tracker of when the changes are both done and merged, because yay granularity!