Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixup the wireshark lua packet dissector heuristic filter
This fixes a bug where the first SCION packet in a capture is never dissected as a SCION packet. The filter function is (only) called on the first packet of the conversation (4-tuple) since we set the dissector for the conversation. To also dissect the initial packet of a conversation for which a heuristic dissector function is registered, the dissector has to be called explicitly at the end of the filter function when a packet matches. From the docs: https://www.wireshark.org/docs/wsdg_html/#lua_fn_proto_register_heuristic_listname__func_ >The function should perform as much verification as possible to ensure the payload is for it, and **dissect the packet** (including setting TreeItem info and such) only if the payload is for it, before returning true or false. Also look at the comments there: https://github.com/wireshark/wireshark/blob/master/test/lua/dissector.lua#L523 https://github.com/wireshark/wireshark/blob/afff4e02/test/lua/dissector.lua#L523
- Loading branch information