Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Feature ] Dependency Updater #3258

Closed
wants to merge 1 commit into from

Conversation

PhoneDroid
Copy link
Contributor

@PhoneDroid PhoneDroid commented Mar 22, 2024

Created updater script & workflow.

Description:

  • Update-Dependency.sh exports the update function
  • Update-Dependencies.sh contains the export definitions & optional push logic
  • Scripts can be tested with a dry-run variable
  • Workflow sets github name / email used for committing
  • Commits are per dependency and contain the their name
  • update parameters are guarded
  • Any realistic error case is logged / guarded
  • script should exit if any update result is a failure
  • script should not exit if anything inside the update function fails ( handled failures )
  • update function allows to specify the remote repo name & url , the DarkRP
    ( local ) folder/file as well as an optional folder in the remote repository
  • Only commits if dependency had any changes
  • Only pushes if there are any new commits

Should be compatible with the current dependency structure and flexible for future changes.

No Params / No Remote

image

No Repository

image

No Target

image

Actual Run

Some dependencies seem to be actually out of date
image
image
image

@FPtje
Copy link
Owner

FPtje commented Mar 24, 2024

Thanks for the contribution, though I think this feature goes a bit too far. Generally I update other repos manually. I don't always do this immediately. One example where I wait, is when e.g. FPP has a risky change, that should be on FPP itself first before I import it into DarkRP.

I prefer to stick to this workflow for now.

@FPtje FPtje closed this Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants