Add condition to Selector call #694
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-592
to
+596
| ((void(*)(id, SEL))objc_msgSend)( | ||
| slf, swizzledSelector | ||
| ); | ||
| if ([slf respondsToSelector:swizzledSelector]) { | ||
| ((void(*)(id, SEL))objc_msgSend)( | ||
| slf, swizzledSelector | ||
| ); | ||
| } |
There was a problem hiding this comment.
I don't think this check is necessary, since NSURLConnection will always implement -cancel. Do you agree?
Comment on lines
-683
to
+689
|
|
||
| ((void(*)(id, SEL))objc_msgSend)( | ||
| slf, swizzledSelector | ||
| ); | ||
| if ([slf respondsToSelector:swizzledSelector]) { | ||
| ((void(*)(id, SEL))objc_msgSend)( | ||
| slf, swizzledSelector | ||
| ); | ||
| } |
Comment on lines
-748
to
+761
| ((void(*)(id, SEL, id, id, id))objc_msgSend)( | ||
| slf, swizzledSelector, request, queue, wrapper | ||
| ); | ||
| if ([slf respondsToSelector:swizzledSelector]) { | ||
| ((void(*)(id, SEL, id, id, id))objc_msgSend)( | ||
| slf, swizzledSelector, request, queue, wrapper | ||
| ); | ||
| } | ||
| } else { | ||
| ((void(*)(id, SEL, id, id, id))objc_msgSend)( | ||
| slf, swizzledSelector, request, queue, completion | ||
| ); | ||
| if ([slf respondsToSelector:swizzledSelector]) { | ||
| ((void(*)(id, SEL, id, id, id))objc_msgSend)( | ||
| slf, swizzledSelector, request, queue, completion | ||
| ); | ||
| } |
There was a problem hiding this comment.
These as well, if I am reading correctly and these are on NSURLConnection
NSExceptional
requested changes
Jun 20, 2024
There was a problem hiding this comment.
I stopped reviewing the PR when I realized just how many of these changes you made.
Can you add the check in the one place you need it instead of everywhere? There is an overhead to using respondsToSelector:, so we should only use it when we know the method might be optional, not in cases where we are swizzling methods that are guaranteed to exist.
NSExceptional
added
awaiting changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I created the
URLSessionDelegateimplementation, app crashed because I didn't implement some optional protocol methods andslfdoesn't respond to those method selectors.For example, for protocol
URLSessionDataDelegateI didn't implement functionoptional func urlSession(_ session: URLSession, dataTask: URLSessionDataTask, didReceive data: Data)