Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for nested global entries #651

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

revolter
Copy link
Contributor

Please review each commit separately, as this PR is logically split into multiple "slow" transitions from the current implementation to the new one.

@revolter
Copy link
Contributor Author

In Swift, if you don't use the closure argument, like this:

FLEXManager.shared.registerGlobalEntry(withName: "Name") { _ in
    print("Log")
}

you now get the build error:

Ambiguous use of 'registerGlobalEntry'

and the only workaround that I can think of is changing the call to:

FLEXManager.shared.registerGlobalEntry(withName: "Name") { (_: UITableViewController) in
    print("Log")
}

or

FLEXManager.shared.registerGlobalEntry(withName: "Name") { (_: FLEXUserGlobalEntriesContainer) in
    print("Log")
}

But this means that you have to look into FLEX's files to find this out, if you're new to it.


So, I will rename the new method (from Swift's POV, the first parameter name), to avoid this ambiguity:

FLEXManager.shared.registerNestedGlobalEntry(withName: "Name") { _ in
    print("Log")
}

@revolter
Copy link
Contributor Author

@NSExceptional, do you have time to look over this? 😁

@NSExceptional
Copy link
Collaborator

Not at the moment no; I was actually in a serious car accident on Tuesday and just got out of the hospital yesterday 🤕

I reviewed a PR yesterday but it was just a small bug fix

@NSExceptional
Copy link
Collaborator

I'll try to get to this when I can use my hand again

@revolter
Copy link
Contributor Author

OMG, I'm so sorry to hear that 😱 Forget about this PR, get well soon 🤗

@revolter
Copy link
Contributor Author

I also added support for optionally customizing the cell accessory type:

Before After

@revolter revolter force-pushed the add/nested-global-entries branch from 544945a to 5c4a218 Compare August 4, 2023 12:28
@NSExceptional
Copy link
Collaborator

Hey dawg! I'm finally getting around to clearing out all these PRs and issues that have accumulated over the last year. Sorry for the delay. I appreciate your patience (and frequent contributions).

Still reviewing, but I'm curious, what's the use case for changing the cell accessory type?

@NSExceptional NSExceptional added enhancement awaiting response … from the author, to proceed labels Aug 25, 2024
@revolter revolter force-pushed the add/nested-global-entries branch from 5c4a218 to 94b6883 Compare August 25, 2024 16:50
@revolter
Copy link
Contributor Author

Hey dawg! I'm finally getting around to clearing out all these PRs and issues that have accumulated over the last year. Sorry for the delay. I appreciate your patience (and frequent contributions).

Hey man! Glad to have you back ❤️

Still reviewing, but I'm curious, what's the use case for changing the cell accessory type?

It's to be able to distinguish nested menus (Level 2 - Nested) from "leaf" menus (Level 2 - Action):

Simulator Screenshot - iPhone 15 (Default) - 2024-08-25 at 19 48 16

I force-pushed a rebase and also fixed the conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting response … from the author, to proceed enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants