Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve perofrmance of combine_coding_and_quantity_values #241

Merged
merged 6 commits into from
Sep 11, 2023
Merged

improve perofrmance of combine_coding_and_quantity_values #241

merged 6 commits into from
Sep 11, 2023

Conversation

danieldubrovski
Copy link
Contributor

should be faster on large resources

mint-thompson
mint-thompson previously approved these changes Sep 8, 2023
View reviewed changes
Copy link
Collaborator

@mint-thompson mint-thompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks fine to me. Thank you for submitting this PR!

cmoesel
cmoesel requested changes Sep 8, 2023
View reviewed changes
Copy link
Member

@cmoesel cmoesel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution! I think it's a very smart approach. I like it!

I made a few minor suggestions for your consideration.

src/optimizer/plugins/CombineCodingAndQuantityValuesOptimizer.ts Outdated Show resolved Hide resolved
src/optimizer/plugins/CombineCodingAndQuantityValuesOptimizer.ts Outdated Show resolved Hide resolved
src/optimizer/plugins/CombineCodingAndQuantityValuesOptimizer.ts Outdated Show resolved Hide resolved
src/optimizer/plugins/CombineCodingAndQuantityValuesOptimizer.ts Outdated Show resolved Hide resolved
cmoesel
cmoesel approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@cmoesel cmoesel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for making GoFSH better!

@cmoesel
Copy link
Member

cmoesel commented Sep 11, 2023

GitHub Actions seem to be stuck, but I ran the tests and lint locally -- and it's all good -- so I will force the merge.

@cmoesel cmoesel merged commit 03b73ee into FHIR:master Sep 11, 2023
@danieldubrovski danieldubrovski deleted the combine_coding_and_quantity_values branch September 12, 2023 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mint-thompson mint-thompson mint-thompson approved these changes

@cmoesel cmoesel cmoesel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danieldubrovski @cmoesel @mint-thompson