Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solve icb related segfault #638

Merged
merged 1 commit into from
Oct 21, 2024
Merged

solve icb related segfault #638

merged 1 commit into from
Oct 21, 2024

Conversation

ackerlar
Copy link
Collaborator

Another last-minute fix... Hopefully, the last one!

@JanStreffing JanStreffing added this to the FESOM 2.6 milestone Oct 21, 2024
@JanStreffing JanStreffing added the bug Something isn't working label Oct 21, 2024
@JanStreffing JanStreffing requested review from JanStreffing and removed request for JanStreffing October 21, 2024 07:21
@JanStreffing
Copy link
Collaborator

Just to document, what was the issue in the end?

@ackerlar
Copy link
Collaborator Author

Single model icebergs could have been assigned to multiple PEs (during the check for cell saturation). During the MPI communication, this could lead to iceberg elements > elem2D

@ackerlar ackerlar merged commit 7f374ae into main Oct 21, 2024
4 checks passed
@JanStreffing JanStreffing deleted the fix/icb_segfault branch October 21, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants