Workbench mainf26 icepack #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
patrickscholz
commented
Oct 18, 2024
patrickscholz
commented
- fix freshwater balancing with icepack thus making icepack volume conserving with ALE zstar
- fix icepack restart for netcdf restarts and raw restarts, make sure that restart are also volume conserving
- fix a couple of bugs in the driver interface of icepack
- fix two bugs in icepack itself see: https://github.com/lzampier/Icepack/tree/icepack_fesom2_bugfix
…estart. This still needs to be checked
…moment Volume is not conserved
…star, there are also two changes in icepack itself
…in ../src/icepack_drivers/icedrv_transfer.F90
… dimension properly
… parameter for def_node_var_3d
… also the restart is volume conserving. Also only write eiter .ice. or .icepack. restart files
…fesom2 into workbench_mainf26_icepack
…om2 into icepack_fesom2_bugfix
JanStreffing
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
A couple of debug write statements are left with !PS. However, since @fkauker might still work more on this, I think it's ok to merge them in, commented out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.