Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker multiplatform build and caching #754

Merged
merged 17 commits into from
Dec 8, 2024
Merged

Docker multiplatform build and caching #754

merged 17 commits into from
Dec 8, 2024

Conversation

realkaranvir
Copy link
Contributor

On pull requests the workflow only builds for arm64 due to speed and doesn't push to dockerhub. On pushes or merges to main it creates the docker image for both linux/amd64 and linux/arm64 builds. Uses github actions cache to speed up builds and uses parallel runners for each architecture.

Copy link
Contributor

@thekevinWHYuan thekevinWHYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@StarDylan StarDylan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@JLpro-cd JLpro-cd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@bholt13 bholt13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

reverted docker compose to build local image
@realkaranvir realkaranvir merged commit c2f6047 into master Dec 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants