Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

created github actions workflow for docker image pushing #748

Merged
merged 2 commits into from
Nov 19, 2024
Merged

created github actions workflow for docker image pushing #748

merged 2 commits into from
Nov 19, 2024

Conversation

realkaranvir
Copy link
Contributor

Github actions workflow that pushes the docker image on push to main. On pull requests it just runs the docker build to see if that succeeds.

bholt13
bholt13 approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@bholt13 bholt13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thekevinWHYuan
Copy link
Contributor

LGTM!

JLpro-cd
JLpro-cd approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@JLpro-cd JLpro-cd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@realkaranvir realkaranvir merged commit 260efe3 into master Nov 19, 2024
4 checks passed
@realkaranvir realkaranvir deleted the dockerbuild_karan branch December 10, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thekevinWHYuan thekevinWHYuan thekevinWHYuan approved these changes

@bholt13 bholt13 bholt13 approved these changes

@JLpro-cd JLpro-cd JLpro-cd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@realkaranvir @thekevinWHYuan @JLpro-cd @bholt13