Meet-The-Admins Section

[mmcbride2929]

TL/DR

This PR updates the admin section by adding new admin photos + their titles

Overview of Change

Members.jsx

• Add new members + their titles
• Add <h5> for newly added member titles

index.css

• Commented out padding .75em from .member class (temporary based on opinion)
• Add styling for admins name and titles (h4 & h5's)
• change member className to admin/member-avatar
• edit array so we can seperate first and last name
• add id to admin so we always have unique keys

With Padding:

Without Padding:

[netlify]

✅ Deploy Preview for production-fcc-columbus ready!

Name	Link
🔨 Latest commit	4a29837
🔍 Latest deploy log	https://app.netlify.com/sites/production-fcc-columbus/deploys/64cbe197deb62a0008019c8f
😎 Deploy Preview	https://deploy-preview-58--production-fcc-columbus.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[jduffey]

This PR is asking to merge into the upstream main instead of dev. Unless there's a way to change that after the PR has been opened, you'll need to close this PR and open a new one. At a quick glance and npm test && npm start, it looks great! I'll do a formal review of the actual code changes once I have more time and the PR is pointing toward the correct upstream target (dev).

[readysetagile]

yeah I had to change the default branch back to main because of #57 . Another side-effect is that we will have to be aware of the base branch where our PRs will go.

It's also easy to change the base branch. You can just edit the PR title and you will get the option. The next commit pushed to the PR will also trigger the correct checks.

[readysetagile]

+1 on the "no padding". it looks a lot better.

Also, I think that a "forced" new line (a <br> element) in-between everyone's first and last name looks better IMO.

[netlify]

✅ Deploy Preview for dev-fcccolumbus ready!

Name	Link
🔨 Latest commit	53af707
🔍 Latest deploy log	https://app.netlify.com/sites/dev-fcccolumbus/deploys/64d2361f16002c000725b425
😎 Deploy Preview	https://deploy-preview-58--dev-fcccolumbus.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[mmcbride2929]

I have updated the css & made a new entry for the admin's first and last name values. I have also added the name above the photo because I thought it looked a little better. Let me know what you think, if it doesn't work i'll be happy to switch it back.

Before

After

[readysetagile]

I'm good with the names on top.

@jduffey are you going to review or are you waiting for me?

Also, FYI, this section is not "responsive", that is, the section does not scale with the changing dimensions. It is not a requirement for the site or this issue yet, so no changes needed. We will have to revisit this at a later time to make decisions on the responsiveness..

[jduffey]

I'm good with the names on top.

@jduffey are you going to review or are you waiting for me?

Also, FYI, this section is not "responsive", that is, the section does not scale with the changing dimensions. It is not a requirement for the site or this issue yet, so no changes needed. We will have to revisit this at a later time to make decisions on the responsiveness..

@readysetagile & @mmcbride2929 I have two pending comments. Overall things look great, I'm happy with the new design.

[jduffey]

Approved. Looks great and thanks for addressing the second round of comments.