Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Discord Nav/Footer Link #52

Merged
merged 4 commits into from
Aug 2, 2023
Merged

Conversation

mmcbride2929
Copy link
Collaborator

TL/DR

This PR updates the discord link within the Nav & Footer to navigate the user to the FCC discord invite page

Overview of Change

links.js

  • update discord href to navigate to discord invite screen

Header.test.js

  • imported screen & render from testing-library
  • wrote test to make sure we are rendering 'Discord' as the third item

Footer.test.js

  • imported screen & render from testing-library
  • wrote test to make sure we are rendering 'Discord' as the third item

@netlify
Copy link

netlify bot commented Jul 30, 2023

Deploy Preview for dev-fcccolumbus ready!

Name Link
🔨 Latest commit 16dce37
🔍 Latest deploy log https://app.netlify.com/sites/dev-fcccolumbus/deploys/64ca78ac8f8c030008a8fdef
😎 Deploy Preview https://deploy-preview-52--dev-fcccolumbus.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

src/links.js Outdated Show resolved Hide resolved
src/links.js Outdated Show resolved Hide resolved
@readysetagile readysetagile linked an issue Aug 1, 2023 that may be closed by this pull request
Copy link
Collaborator

@readysetagile readysetagile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments within.

  • use the correct link
  • remove the "third link" test
  • remove the changed files which did not require changes

src/components/Events.jsx Outdated Show resolved Hide resolved
src/links.js Outdated Show resolved Hide resolved
src/test/__snapshots__/App.test.js.snap Show resolved Hide resolved
src/test/components/Footer.test.js Outdated Show resolved Hide resolved
src/test/components/__snapshots__/Footer.test.js.snap Outdated Show resolved Hide resolved
src/test/components/__snapshots__/Header.test.js.snap Outdated Show resolved Hide resolved
src/test/__snapshots__/App.test.js.snap Outdated Show resolved Hide resolved
src/test/__snapshots__/App.test.js.snap Outdated Show resolved Hide resolved
src/test/components/Header.test.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@jduffey jduffey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All comments were addressed. Discord link now points to John's invite link. Approving.

src/test/components/Footer.test.js Outdated Show resolved Hide resolved
src/test/components/Header.test.js Outdated Show resolved Hide resolved
src/test/components/Footer.test.js Outdated Show resolved Hide resolved
src/links.js Outdated Show resolved Hide resolved
@readysetagile readysetagile merged commit e49fa90 into FCCColumbus:dev Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link webpage to Discord
3 participants