get current location for overview map center, put a marker there #1242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Cassidy <[email protected]>
|
Have a strange issue where it worked once but doesn't seem to work every time |
PeterBaker0
reviewed
Nov 28, 2024
| type: 'Feature', | ||
| geometry: { | ||
| type: 'Point', | ||
| coordinates: map_center, |
There was a problem hiding this comment.
is this safe if data is undefined - what's the behaviour?
There was a problem hiding this comment.
Have put a guard around this.
Signed-off-by: Steve Cassidy <[email protected]>
Signed-off-by: Steve Cassidy <[email protected]>
Signed-off-by: Steve Cassidy <[email protected]>
PeterBaker0
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Works well after discussed changes re: race conditions.
Would recommend some refactoring when we visit it again to do with error conditions and not relying on react query isLoading to check if something is happening 'for the first time' - would prefer refs to track this if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get current location for overview map center
JIRA Ticket
None
Description
The overview map had a fixed center point somewhere in Africa. More useful to move it
to the current location.
Proposed Changes
How to Test
Open a notebook with geo-locations (BSS) and view the Map. See the cross at your current location.
Move the map, click the circle 'center map' button and see it center the map on your location.
Checklist