Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert change to takephoto callback #1227

Merged
merged 1 commit into from
Nov 10, 2024
Merged

revert change to takephoto callback #1227

merged 1 commit into from
Nov 10, 2024

Conversation

stevecassidy
Copy link
Contributor

Fix TakePhoto doesn't work

JIRA Ticket

None

Description

TakePhoto wasn't working following a recent change.

Proposed Changes

Revert the callback to use an async/await.

How to Test

Take a photo!

Checklist

  • I have confirmed all commits have been signed.
  • I have added JSDoc style comments to any new functions or classes.
  • Relevant documentation such as READMEs, guides, and class comments are updated.

Copy link
Contributor

@PeterBaker0 PeterBaker0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming you tested that this fixes the issue - lgtm. Thanks.

@stevecassidy stevecassidy merged commit a834d5e into main Nov 10, 2024
2 checks passed
@stevecassidy stevecassidy deleted the take-photo-this-fix branch November 10, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants