Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improved wording for active and not-active #1225

Merged
merged 7 commits into from
Nov 11, 2024

Conversation

ranisa-gupta16
Copy link
Contributor

@ranisa-gupta16 ranisa-gupta16 commented Nov 10, 2024

feat: improved wording for active and not-active

Description

Update the wording as per discussion - make these values consistent and configurable to make edits faster in the future.

Screenshots

Notebook list (headings)

image

Notebook list (tabs)

image

Activate warning

image

Checklist

  • I have confirmed all commits have been signed.
  • I have added JSDoc style comments to any new functions or classes.
  • Relevant documentation such as READMEs, guides, and class comments are updated.

Copy link
Contributor

@PeterBaker0 PeterBaker0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tab is confusing wording for headings layout.

app/src/gui/components/workspace/notebooks.tsx Outdated Show resolved Hide resolved
@PeterBaker0 PeterBaker0 changed the title Update list of surveys wording feat: improved wording for active and not-active Nov 10, 2024
Signed-off-by: Peter Baker <[email protected]>
Signed-off-by: Peter Baker <[email protected]>
@PeterBaker0 PeterBaker0 merged commit 51e005a into main Nov 11, 2024
2 checks passed
@PeterBaker0 PeterBaker0 deleted the update-list-of-surveys-wording branch November 11, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants