Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: survey list home page #1118

Merged
merged 4 commits into from
Aug 20, 2024
Merged

Conversation

luke-mcfarlane-rocketlab
Copy link
Contributor

JIRA Ticket

BSS-129

Description

Update home page to be the survey list page.

Proposed Changes

  • updated survey list to be on "/" route
  • removed current component on "/" route
  • updated all links to survey list to the "/" route

How to Test

  • log in to app
  • home page should be survey list page
  • try navigating away and back by clicking the logo/sidebar link
  • log out of the app
  • try navigating to http://localhost:3000/ and verify it redirects to the sign in page

Additional Information

Checklist

  • I have confirmed all commits have been signed.
  • I have added JSDoc style comments to any new functions or classes.
  • Relevant documentation such as READMEs, guides, and class comments are updated.

…idebar, updated all links to workspace

Signed-off-by: Luke McFarlane <[email protected]>
Signed-off-by: Luke McFarlane <[email protected]>
@stevecassidy
Copy link
Contributor

Should we redirect to the home page (survey list) after login? Currently it returns you to the login page and you need to click on "Workspace" to get there.

@luke-mcfarlane-rocketlab
Copy link
Contributor Author

Should we redirect to the home page (survey list) after login? Currently it returns you to the login page and you need to click on "Workspace" to get there.

Agree with this, will update and re-request.

@luke-mcfarlane-rocketlab
Copy link
Contributor Author

@stevecassidy actioned

Copy link
Contributor

@stevecassidy stevecassidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good.

@luke-mcfarlane-rocketlab luke-mcfarlane-rocketlab merged commit 40efa96 into main Aug 20, 2024
2 checks passed
@luke-mcfarlane-rocketlab luke-mcfarlane-rocketlab deleted the feat/survey-list-home-page branch August 20, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants