Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: turbo cache, generic build dockerfile, dependency caching in github actions #1116

Merged
merged 21 commits into from
Aug 20, 2024

Conversation

PeterBaker0
Copy link
Contributor

@PeterBaker0 PeterBaker0 commented Aug 15, 2024

Makes various build improvements

  • utilises turbo repo remote cache in build and lint pipeline
  • produces an automated Dockerfile.build which is capable of building any node based target in the monorepo without specifying manually the dependencies to bundle in the output
  • updates README to explain Dockerfile.build
  • utilises npm i cache in the Github Actions

@PeterBaker0 PeterBaker0 changed the title Adds fix and build outputs to turbo config build: turbo cache, generic build dockerfile, dependency caching in github actions Aug 15, 2024
@luke-mcfarlane-rocketlab
Copy link
Contributor

LGTM - tested locally, and reviewed actions output

Copy link
Contributor

@stevecassidy stevecassidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good. My only comment is tangential - I updated the node version in a few places to 20.9.0 for an earlier PR but note that you're just specifying node 20 in a few places here. That sounds like a better idea so should we use a less specific version in the engines clause in package.lock?

@PeterBaker0 PeterBaker0 merged commit d87896c into main Aug 20, 2024
2 checks passed
@PeterBaker0 PeterBaker0 deleted the chore/add-build-outputs-to-turbo branch August 20, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants