-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: turbo cache, generic build dockerfile, dependency caching in github actions #1116
Conversation
Signed-off-by: Peter Baker <[email protected]>
Signed-off-by: Peter Baker <[email protected]>
Signed-off-by: Peter Baker <[email protected]>
Signed-off-by: Peter Baker <[email protected]>
Signed-off-by: Peter Baker <[email protected]>
Signed-off-by: Peter Baker <[email protected]>
Signed-off-by: Peter Baker <[email protected]>
Signed-off-by: Peter Baker <[email protected]>
…ware bundling script, update pipeline Signed-off-by: Peter Baker <[email protected]>
Signed-off-by: Peter Baker <[email protected]>
Signed-off-by: Peter Baker <[email protected]>
Signed-off-by: Peter Baker <[email protected]>
Signed-off-by: Peter Baker <[email protected]>
Signed-off-by: Peter Baker <[email protected]>
Signed-off-by: Peter Baker <[email protected]>
Signed-off-by: Peter Baker <[email protected]>
Signed-off-by: Peter Baker <[email protected]>
LGTM - tested locally, and reviewed actions output |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good. My only comment is tangential - I updated the node version in a few places to 20.9.0 for an earlier PR but note that you're just specifying node 20 in a few places here. That sounds like a better idea so should we use a less specific version in the engines clause in package.lock?
…ility Signed-off-by: Peter Baker <[email protected]>
Signed-off-by: Peter Baker <[email protected]>
Signed-off-by: Peter Baker <[email protected]>
Makes various build improvements
npm i
cache in the Github Actions