Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: map component zoom buttons #1110

Merged
merged 4 commits into from
Aug 15, 2024

Conversation

luke-mcfarlane-rocketlab
Copy link
Contributor

JIRA Ticket

BSS-288

Description

Added zoom buttons to the map component.

Proposed Changes

  • Updated map component to use the OL zoom component
  • Updated styling of zoom component using default classnames in global css file

How to Test

  1. Activate "Campus Survey Demo" if it is not already activated
  2. Open the survey "Campus Survey Demo"
  3. Click the "+ Survey Area" button to add a new survey area
  4. Click the "DRAW BOUNDING BOX AROUND SURVEY AREA"
  5. Test the zoom in and out buttons on the bottom left of the map screen

Additional Information

No config to allow turning this feature has been added yet but we could easily add this in the future.

Checklist

  • I have confirmed all commits have been signed.
  • I have added JSDoc style comments to any new functions or classes.
  • Relevant documentation such as READMEs, guides, and class comments are updated.

Copy link
Contributor

@PeterBaker0 PeterBaker0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on browser and with phone simulation in browser and works well. Styling is okay maybe slightly hard to spot on larger screens - it could scale to be larger - but lgtm.

@luke-mcfarlane-rocketlab luke-mcfarlane-rocketlab merged commit 795fbd6 into main Aug 15, 2024
2 checks passed
@luke-mcfarlane-rocketlab luke-mcfarlane-rocketlab deleted the feat/map-component-zoom-buttons branch August 15, 2024 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants