Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook Creator Role #390

Merged
merged 11 commits into from
Dec 14, 2023
Merged

Notebook Creator Role #390

merged 11 commits into from
Dec 14, 2023

Conversation

stevecassidy
Copy link
Contributor

Add a new role for users to allow them to create notebooks without being cluster admin. This will be assigned to new users so they can create and manage their own notebooks.

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (d305afb) 58.41% compared to head (a3c11c5) 60.45%.

Files Patch % Lines
src/api/routes.ts 76.19% 3 Missing and 2 partials ⚠️
src/couchdb/notebooks.ts 44.44% 3 Missing and 2 partials ⚠️
src/couchdb/users.ts 77.77% 1 Missing and 1 partial ⚠️
src/core.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #390      +/-   ##
==========================================
+ Coverage   58.41%   60.45%   +2.04%     
==========================================
  Files          21       21              
  Lines        1539     1535       -4     
  Branches      256      258       +2     
==========================================
+ Hits          899      928      +29     
+ Misses        519      481      -38     
- Partials      121      126       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevecassidy stevecassidy merged commit 430afe2 into main Dec 14, 2023
8 checks passed
@stevecassidy stevecassidy deleted the notebook-admin-user branch December 14, 2023 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant