update permissions for notebook creation and test

Signed-off-by: Steve Cassidy <[email protected]>

src/api/routes.ts

@@ -44,6 +44,7 @@ import {
   saveUser,
   userHasPermission,
   userIsClusterAdmin,
+  userCanCreateNotebooks,
 } from '../couchdb/users';
 import {
   CLUSTER_ADMIN_GROUP_NAME,
@@ -87,20 +88,24 @@ api.get('/notebooks/', requireAuthenticationAPI, async (req, res) => {
  * POST to /notebooks/ to create a new notebook
  */
 api.post('/notebooks/', requireAuthenticationAPI, async (req, res) => {
-  // post a new notebook
-  // user must be cluster admin
-
-  if (userIsClusterAdmin(req.user)) {
+  if (req.user && userCanCreateNotebooks(req.user)) {
     const uiSpec = req.body['ui-specification'];
     const projectName = req.body.name;
     const metadata = req.body.metadata;
 
     try {
       const projectID = await createNotebook(projectName, uiSpec, metadata);
-      res.json({notebook: projectID});
+      if (projectID) {
+        // allow this user to modify the new notebook
+        addProjectRoleToUser(req.user, projectID, 'admin');
+        await saveUser(req.user);
+        res.json({notebook: projectID});
+      } else {
+        res.json({error: 'error creating the notebook'});
+        res.status(500).end();
+      }
     } catch (err) {
       res.json({error: 'there was an error creating the notebook'});
-      console.log('Error creating notebook', err);
       res.status(500).end();
     }
   } else {

src/couchdb/notebooks.ts

@@ -857,6 +857,9 @@ export async function countRecordsInNotebook(
   const dataDB = await getDataDB(project_id);
   try {
     const res = await dataDB.query('index/recordCount');
+    if (res.rows.length === 0) {
+      return 0;
+    }
     return res.rows[0].value;
   } catch (error) {
     console.log(error);

src/couchdb/users.ts

@@ -21,7 +21,10 @@
 
 import {ProjectRole} from 'faims3-datamodel/build/src/types';
 import {getUsersDB} from '.';
-import {CLUSTER_ADMIN_GROUP_NAME, NOTEBOOK_CREATOR_GROUP_NAME} from '../buildconfig';
+import {
+  CLUSTER_ADMIN_GROUP_NAME,
+  NOTEBOOK_CREATOR_GROUP_NAME,
+} from '../buildconfig';
 import {NonUniqueProjectID, ProjectID} from 'faims3-datamodel';
 import {
   AllProjectRoles,