Don't allow players to friend or foe themselves #315
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't make sense to allow friend/foe relationships to ones self. Are we supposed to hide our own chat messages from ourselves if we are our own foe? Are we supposed to be disallowed from playing a game with ourselves?
I think the client already isn't supposed to allow you to do this, but I can see in the server logs that sometimes this is attempted. I would be curious to know the number of self referential rows there are on prod.