Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow players to friend or foe themselves #315

Merged

Conversation

Askaholic
Copy link
Collaborator

It doesn't make sense to allow friend/foe relationships to ones self. Are we supposed to hide our own chat messages from ourselves if we are our own foe? Are we supposed to be disallowed from playing a game with ourselves?

I think the client already isn't supposed to allow you to do this, but I can see in the server logs that sometimes this is attempted. I would be curious to know the number of self referential rows there are on prod.

select count(*) from friends_and_foes where user_id=subject_id;

@Askaholic Askaholic force-pushed the friend_and_foe_self_references branch from aab1f6e to 9e7e5a0 Compare January 12, 2024 05:38
@Askaholic Askaholic force-pushed the friend_and_foe_self_references branch from 9e7e5a0 to d2c5703 Compare January 12, 2024 05:46
@Brutus5000
Copy link
Member

We have 43 self-hating users.

@Brutus5000 Brutus5000 merged commit ee486dd into FAForever:develop Jan 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants