-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add featured mods for missions #196
Conversation
d1f9f45
to
e78ec84
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need 2 additional tables? Just add a foreign key to coop_map with reference to the featured mod.
no we need both, for nomands coop we need to download and update coop featured mod and nomands featured mod and then start nomands featured mod. And maybe we have some other coop that depends on several featured mods.... |
It seems like @Exotic-Retard needs to write what is needed... Are both coop and nomands neeed to launch nomads coop. And are special versions needed or will the newest version always we the correct one. Which init needs to be launched...????? |
1.Newest version of nomads will always be the correct one |
Oder man checkt im modifizierten nomands init ob es eine coop mission ist und launcht das entsprechende init. Na ja ka aber es gibt meinem Schema eigentlich Recht. Außer Brutus will eine weitere featured mod anlegen, die beides kombiniert. Musst du wissen Brutus.... |
Completely forgot should write English Or you check in the modified nomands init if it is a coop mission and launch the corresponding init. Well no idea but it actually shows why my scheme makes sense. Well only in case Brutus does not want to create another featured mod that combines both.You need to know Brutus.... |
|
Well my solution would also offer making a new mod for nomands coop with only the init file and nothing else. Then enter nomands and coop as secondary/needed featured mods and tada |
A joined featured mod might be hard to update... At least thats what I fear |
I don't think we can allow multi-featured mod dependencies. If I understand correctly then
If nomads coop now depends on coop and nomads we'd need to introduce some sort of dependency management to resolve order of loading etc. This is a complexity that we need to avoid at all cost. |
ok so we try to make a combi featured mod... |
We can write a py script that reads the db tables and joins them and adds the extra init. Maybe like this. |
The first batch of tasks to achieve the goal of this issue is outlined in https://github.com/orgs/FAForever/projects/8 |
Fixes #163