Refactoring Chain of Responsability example

EzeCuccorese · Nov 21, 2019 · 50b8fa0 · 50b8fa0
1 parent b738911
commit 50b8fa0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/chain/examples/army/Officer.java b/src/chain/examples/army/Officer.java
@@ -13,7 +13,7 @@ public Officer(String name, String order) {
     public String order() {
     	String result=null;
 
-    	if(super.order()!=null && !super.order().equals("(sin orden)")) {
+    	if(super.order()!=null && !super.order().equals(UNKNOWN_ORDER)) {
     		result = super.order();
 
     	}else if (_order != null) {

diff --git a/src/chain/examples/army/Unit.java b/src/chain/examples/army/Unit.java
@@ -2,6 +2,8 @@
 
 public abstract class Unit {
 
+	static final String UNKNOWN_ORDER = "(sin orden)";
+
 	private Unit _command;
     private String _name;
 
@@ -19,6 +21,6 @@ public void setCommand(Unit command) {
     }
 
     public String order() {
-        return (_command != null ? _command.order() : "(sin orden)"); 
+        return (_command != null ? _command.order() : UNKNOWN_ORDER); 
     }
 }