feat: when mediaconvert job fails log message #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oshinongit
force-pushed
the
feat-log-transcode-errors
branch
from
e5c0fc5
to
fd49bae
Compare
oshinongit
force-pushed
the
feat-log-transcode-errors
branch
from
fd49bae
to
883f2ba
Compare
|
Should rethink when to check for job error. Current suggestion only considers during job creation. |
oshinongit
force-pushed
the
feat-log-transcode-errors
branch
5 times, most recently
from
7289763
to
db0b55f
Compare
grusell
approved these changes
Oct 4, 2024
src/pipelines/aws/aws-pipeline.ts
Outdated
| logger.error(`No Job from create response ${inputFilename}`); | ||
| return ''; | ||
| } | ||
| const s3Status = await this.loopGetJobStatusUntilFinished( |
There was a problem hiding this comment.
Name of variable could be better, ie mediaConvertJobStatus or so.
src/pipelines/aws/aws-pipeline.ts
Outdated
| } | ||
| } | ||
|
|
||
| async delay_ms(ms: number): Promise<void> { |
There was a problem hiding this comment.
Since this function is pretty generic and not really tied to the aws-pipeline, it could make sense to move it somewhere else, utils.ts or something. Also for consistency the name should be delayMs or just delay.
oshinongit
force-pushed
the
feat-log-transcode-errors
branch
from
db0b55f
to
ce651aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be good to have mediaconvert error messages be visible in the console.