Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP Staging] Revert "Handle context menu format command" #55127

Merged
merged 1 commit into from
Jan 11, 2025
Merged

[CP Staging] Revert "Handle context menu format command" #55127

merged 1 commit into from
Jan 11, 2025
+5 −17

Conversation

shubham1206agra
Copy link
Contributor

Reverts #54983

Fixes #55115

@shubham1206agra shubham1206agra requested a review from a team as a code owner January 11, 2025 18:12
@melvin-bot melvin-bot bot requested a review from neil-marcellini January 11, 2025 18:12
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jan 11, 2025

@neil-marcellini Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team January 11, 2025 18:12
@shubham1206agra
Copy link
Contributor Author

@neil-marcellini Please wait for @grgia approval here.

@mountiny mountiny changed the title Revert "Handle context menu format command" [CP Staging] Revert "Handle context menu format command" Jan 11, 2025
mountiny
mountiny approved these changes Jan 11, 2025
View reviewed changes
Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight revert, its blocking building the hybrid app in staging #54983 (comment)

@mountiny mountiny merged commit a864b6b into Expensify:main Jan 11, 2025
16 of 19 checks passed
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jan 11, 2025

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot bot added the Emergency label Jan 11, 2025
@mountiny
Copy link
Contributor

Straight revert

OSBotify pushed a commit that referenced this pull request Jan 11, 2025
@mountiny @OSBotify
Merge pull request #55127 from shubham1206agra/revert-54983-fix/53145…
352c99b 
…-handle-format-command

[CP Staging] Revert "Handle context menu format command"

(cherry picked from commit a864b6b)

(CP triggered by mountiny)
@github-actions github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Jan 11, 2025
@github-actions github-actions bot mentioned this pull request Jan 11, 2025
Open
32 tasks
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions GitHub Actions
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.84-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 success ✅
🍎🔄 iOS HybridApp 🍎🔄 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mountiny mountiny mountiny approved these changes

@neil-marcellini neil-marcellini Awaiting requested review from neil-marcellini

Assignees

@shubham1206agra shubham1206agra

Labels
CP Staging marks PRs that have been CP'd to staging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chat - Bold markdown gets triplicated when used as a second markdown in an emoji.
3 participants
@shubham1206agra @mountiny @OSBotify