-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate/textinput growlnotification attachmentmodal animte to reanimate #53321
base: main
Are you sure you want to change the base?
Conversation
Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
review from Błazej Co-authored-by: Błażej Kustra <[email protected]>
…ntmodal_animte_to_reanimate
…ion_attachmentmodal_animte_to_reanimate' into migrate/textinput_growlnotification_attachmentmodal_animte_to_reanimate
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Is there anything here you need us to review from a design-perspective? |
No |
Explanation of Change
Swap use animated from react-native to react-native-reanimated so we have big performance gains in animations
Fixed Issues
$ #52920
PROPOSAL:
here
Tests
Text input
expected behavior:
the label above the text input should move up at the moment of focus on the input
label should return to its original place when focus on text input disappears.
Growl nottification
This is quite hard, the easiest way to do it is to manually add the code that will call it, you need to add the following code:
Growl.show('TEST NOTIFICATION HARDCODED ONLY AS AN EXAMPLE', CONST.GROWL.SUCCESS, 3000);
expected behavior:
A notification with a bounce-in effect containing the text will appear:
TEST NOTIFICATION HARDCODED ONLY AS AN EXAMPLE
Attachment modal:
Animated here is the appearance of the send button in the modal, the animation is not very visible but behaves the same as the one using animated
Offline tests
Are not needed
QA Steps
Same as the tests, in addition, you can also see other text inputs
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android_native.mp4
Android: mWeb Chrome
android.web.mp4
iOS: Native
ios.native.mp4
iOS: mWeb Safari
ios.web.mp4
MacOS: Chrome / Safari
desktop.web.mp4
MacOS: Desktop
desktop.native.mp4