fix: QAB - Without entering any amount, tapping submit expense/pay elsewhere shows diff. behavior. #51929

Krishna2323 · 2024-11-02T22:17:22Z

Explanation of Change

When using the QAB for the FAB, the "done" sound was not played because the transaction was not reaching the confirmation page and the sound was only added in the confirmation page. Additionally, we had not added the sounds in the Manual, Scan, and Distance components to play the sound within those components when the confirmation page is skipped.
This PR fixes the issue by playing the "done" sound in the Manual, Scan, and Distance components when the confirmation page is skipped and transaction is being created.

Fixed Issues

$ #51520
PROPOSAL: #51520 (comment)

Tests

Submit a manual track expense using "Track expense" option in FAB > Verify done sound is played
Use QAB in FAB to submit manual track expense again > Verify done sound is played
Submit a scan track expense using "Track expense" option in FAB > Verify done sound is played
Use QAB in FAB to submit scan track expense again > Verify done sound is played
Submit a distance track expense using "Track expense" option in FAB > Verify done sound is played
Use QAB in FAB to submit distance track expense again > Verify done sound is played
Submit a manual expense to a user using "Submit expense" option in FAB > Verify done sound is played
Use QAB in FAB to submit manual expense again > Verify done sound is played
Submit a scan expense to a user using "Submit expense" option in FAB > Verify done sound is played
Use QAB in FAB to submit scan expense again > Verify done sound is played
Submit a distance expense to a user using "Submit expense" option in FAB > Verify done sound is played
Use QAB in FAB to submit distance expense again > Verify done sound is played
Send invoice to a user > Verify done sound is played
Open a user report > use + in the composer and pay using the Pay {userName} option > Verify success sound is played
Use QAB in FAB to pay the user again > verify success sound is played

Verify that no errors appear in the JS console

Offline tests

Submit a manual track expense using "Track expense" option in FAB > Verify done sound is played
Use QAB in FAB to submit manual track expense again > Verify done sound is played
Submit a scan track expense using "Track expense" option in FAB > Verify done sound is played
Use QAB in FAB to submit scan track expense again > Verify done sound is played
Submit a distance track expense using "Track expense" option in FAB > Verify done sound is played
Use QAB in FAB to submit distance track expense again > Verify done sound is played
Submit a manual expense to a user using "Submit expense" option in FAB > Verify done sound is played
Use QAB in FAB to submit manual expense again > Verify done sound is played
Submit a scan expense to a user using "Submit expense" option in FAB > Verify done sound is played
Use QAB in FAB to submit scan expense again > Verify done sound is played
Submit a distance expense to a user using "Submit expense" option in FAB > Verify done sound is played
Use QAB in FAB to submit distance expense again > Verify done sound is played
Send invoice to a user > Verify done sound is played
Open a user report > use + in the composer and pay using the Pay {userName} option > Verify success sound is played
Use QAB in FAB to pay the user again > verify success sound is played

QA Steps

Submit a manual track expense using "Track expense" option in FAB > Verify done sound is played
Use QAB in FAB to submit manual track expense again > Verify done sound is played
Submit a scan track expense using "Track expense" option in FAB > Verify done sound is played
Use QAB in FAB to submit scan track expense again > Verify done sound is played
Submit a distance track expense using "Track expense" option in FAB > Verify done sound is played
Use QAB in FAB to submit distance track expense again > Verify done sound is played
Submit a manual expense to a user using "Submit expense" option in FAB > Verify done sound is played
Use QAB in FAB to submit manual expense again > Verify done sound is played
Submit a scan expense to a user using "Submit expense" option in FAB > Verify done sound is played
Use QAB in FAB to submit scan expense again > Verify done sound is played
Submit a distance expense to a user using "Submit expense" option in FAB > Verify done sound is played
Use QAB in FAB to submit distance expense again > Verify done sound is played
Send invoice to a user > Verify done sound is played
Open a user report > use + in the composer and pay using the Pay {userName} option > Verify success sound is played
Use QAB in FAB to pay the user again > verify success sound is played

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

…sewhere shows diff. behavior. Signed-off-by: krishna2323 <[email protected]>

melvin-bot · 2024-11-02T22:17:26Z

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hungvu193 · 2024-11-05T08:36:38Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android.mov

Android: mWeb Chrome

mAndroid.mov

iOS: Native

IOS.mov

iOS: mWeb Safari

Safari.mov

MacOS: Chrome / Safari

Chrome.mov

MacOS: Desktop

Dessktop.mov

Gonals · 2024-11-05T12:37:52Z

Linter is filing:
339:38 error 'withOnyx' is deprecated. Use useOnyxinstead ofwithOnyx whenever possible.

hungvu193 · 2024-11-05T15:24:37Z

@Krishna2323 Oops 🤕 . Can you also migrate src/pages/iou/request/step/IOURequestStepAmount.tsx to useOnyx? Ty

Krishna2323 · 2024-11-06T05:06:50Z

@Gonals, I think we can merge this one, the lint fail is automatically fixed after pulling main.

OSBotify · 2024-11-06T10:28:36Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-11-07T13:09:23Z

🚀 Deployed to staging by https://github.com/Gonals in version: 9.0.59-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-11-11T18:14:58Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.0.59-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄	skipped 🚫

fix: QAB - Without entering any amount, tapping submit expense/pay el…

f3ba001

…sewhere shows diff. behavior. Signed-off-by: krishna2323 <[email protected]>

Krishna2323 requested a review from a team as a code owner November 2, 2024 22:17

melvin-bot bot requested a review from hungvu193 November 2, 2024 22:17

melvin-bot bot removed the request for review from a team November 2, 2024 22:17

Merge branch 'Expensify:main' into krishna2323/issue/51520

c98e603

hungvu193 approved these changes Nov 5, 2024

View reviewed changes

melvin-bot bot requested a review from Gonals November 5, 2024 08:37

Merge branch 'main' into krishna2323/issue/51520

fec877a

Gonals approved these changes Nov 6, 2024

View reviewed changes

Gonals merged commit 163e0b5 into Expensify:main Nov 6, 2024
16 checks passed

github-actions bot mentioned this pull request Nov 7, 2024

Deploy Checklist: New Expensify 2024-11-07 #52178

Closed

60 tasks

melvin-bot bot mentioned this pull request Nov 11, 2024

[HOLD for payment 2024-11-18] [$250] QAB - Without entering any amount, tapping submit expense/ pay elsewhere shows diff. behavior #51520

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: QAB - Without entering any amount, tapping submit expense/pay elsewhere shows diff. behavior. #51929

fix: QAB - Without entering any amount, tapping submit expense/pay elsewhere shows diff. behavior. #51929

Krishna2323 commented Nov 2, 2024 •

edited

Loading

melvin-bot bot commented Nov 2, 2024

hungvu193 commented Nov 5, 2024

Gonals commented Nov 5, 2024

hungvu193 commented Nov 5, 2024

Krishna2323 commented Nov 6, 2024

OSBotify commented Nov 6, 2024

github-actions bot commented Nov 7, 2024

github-actions bot commented Nov 11, 2024

fix: QAB - Without entering any amount, tapping submit expense/pay elsewhere shows diff. behavior. #51929

fix: QAB - Without entering any amount, tapping submit expense/pay elsewhere shows diff. behavior. #51929

Conversation

Krishna2323 commented Nov 2, 2024 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Nov 2, 2024

hungvu193 commented Nov 5, 2024

Reviewer Checklist

Screenshots/Videos

Gonals commented Nov 5, 2024

hungvu193 commented Nov 5, 2024

Krishna2323 commented Nov 6, 2024

OSBotify commented Nov 6, 2024

github-actions bot commented Nov 7, 2024

github-actions bot commented Nov 11, 2024

Krishna2323 commented Nov 2, 2024 •

edited

Loading