Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HybridApp] Implement POC of NewDot SignIn on HybridApp #51257

Draft
wants to merge 47 commits into
base: main
Choose a base branch
from
Draft

[HybridApp] Implement POC of NewDot SignIn on HybridApp #51257

wants to merge 47 commits into from

Commits on Oct 22, 2024

  1. Implement POC of NewDot login page on HybridApp

    @mateuuszzzzz
    mateuuszzzzz committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    5eaa292 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. Merge branch 'main' into make-new-dot-signin-default-for-hybridapp

    @war-in
    war-in committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    404047f View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. fix android crash

    @war-in
    war-in committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    f81ec86 View commit details
    Browse the repository at this point in the history

  2. add HybridApp onyx key

    @war-in
    war-in committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    290748d View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. wip - sending native events

    @war-in
    war-in committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    05c4573 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'refs/heads/main' into war-in/unmock-signing-in

    @war-in
    war-in committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    b6e14aa View commit details
    Browse the repository at this point in the history

  3. js logic

    @war-in
    war-in committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    bb05ef9 View commit details
    Browse the repository at this point in the history

  4. fix switching to new experience

    @war-in
    war-in committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    94ebb8f View commit details
    Browse the repository at this point in the history

  5. block switching when still signing in to OD

    @war-in
    war-in committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    a9ff586 View commit details
    Browse the repository at this point in the history

  6. reset onyx values on start

    @war-in
    war-in committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    ec6315e View commit details
    Browse the repository at this point in the history

  7. Merge branch 'refs/heads/main' into make-new-dot-signin-default-for-h… 

    …ybridapp
    @war-in
    war-in committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    db0d806 View commit details
    Browse the repository at this point in the history

  8. preserve HYBRID_APP onyx key when signing out

    @war-in
    war-in committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    e1562bb View commit details
    Browse the repository at this point in the history

  9. fix

    @war-in
    war-in committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    efde805 View commit details
    Browse the repository at this point in the history

  10. move part of resetting logic

    @war-in
    war-in committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    a1b9e1a View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. move useNewDotSignInPage to HybridApp key

    @war-in
    war-in committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    3ad1b62 View commit details
    Browse the repository at this point in the history

  2. fix lint & typecheck

    @war-in
    war-in committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    f9b0e5a View commit details
    Browse the repository at this point in the history

  3. correctly set onyx props when switching from OD

    @war-in
    war-in committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    377b686 View commit details
    Browse the repository at this point in the history

  4. don't set HybridApp key in onyx (merge it)

    @war-in
    war-in committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    90f7c0f View commit details
    Browse the repository at this point in the history

  5. send error message on failed OD login

    @war-in
    war-in committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    4b3e539 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. add useOldDot const

    @war-in
    war-in committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    026ac7b View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Merge branch 'main' into war-in/unmock-signing-in 

    # Conflicts:
#	src/libs/actions/Session/index.ts
    @war-in
    war-in committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    624be42 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'war-in/unmock-signing-in' into make-new-dot-signin-defa… 

    …ult-for-hybridapp
    @war-in
    war-in committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    44dffc8 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Bootsplash logic in hybridapp (#132) 

    * Implement ND bootsplash logic

* Rename param

* Adress review
    @jnowakow
    jnowakow authored Nov 7, 2024
    Configuration menu
    Copy the full SHA
    d976148 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. Merge branch 'main' into make-new-dot-signin-default-for-hybridapp 

    # Conflicts:
#	src/ONYXKEYS.ts
#	src/libs/actions/Session/index.ts
#	src/types/modules/react-native.d.ts
    @war-in
    war-in committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    11e444d View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. fix clearing onyx

    @war-in
    war-in committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    a78141d View commit details
    Browse the repository at this point in the history

  2. [HybridApp] Do not use query params in AppProp URL (#125) 

    * Add hybridAppSettings AppProp

* Unify how we pass data on both platforms

* fix after merge

* fix comments

---------

Co-authored-by: war-in <[email protected]>
    @mateuuszzzzz @war-in
    mateuuszzzzz and war-in authored Nov 13, 2024
    Configuration menu
    Copy the full SHA
    deaba6f View commit details
    Browse the repository at this point in the history

  3. Handle OD sing-in errors (#136) 

    * wip

* block switching when error returned

* make goBack work correctly

* validate code form and SignIn button works (but require further investigation)

* show error when unable to switch to OD

* adjust new sign-up flow

* add comment

---------

Co-authored-by: war-in <[email protected]>
    @war-in
    war-in and war-in authored Nov 13, 2024
    Configuration menu
    Copy the full SHA
    f2e3bb4 View commit details
    Browse the repository at this point in the history

  4. add disabled to button

    @war-in
    war-in committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    8859b6c View commit details
    Browse the repository at this point in the history

  5. move sign in state to HybridApp key

    @war-in
    war-in committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    a3436bc View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. add loading indicator and error modal

    @war-in
    war-in committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    703c31d View commit details
    Browse the repository at this point in the history

  2. move sign in logic to HybridApp.ts

    @war-in
    war-in committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    1f6a0e1 View commit details
    Browse the repository at this point in the history

  3. fix lint

    @war-in
    war-in committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    63a3de8 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. Merge branch 'main' into make-new-dot-signin-default-for-hybridapp

    @mateuuszzzzz
    mateuuszzzzz committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    9fdeebb View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. Merge branch 'main' into make-new-dot-signin-default-for-hybridapp

    @mateuuszzzzz
    mateuuszzzzz committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    4bc9f90 View commit details
    Browse the repository at this point in the history

  2. Prevent closing NewDot on first transition with button

    @mateuuszzzzz
    mateuuszzzzz committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    1a99fd1 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. use "tryNewDot" value to determine which app should be opened

    @war-in
    war-in committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    0e601bd View commit details
    Browse the repository at this point in the history

  2. first step to fix deeplinks

    @war-in
    war-in committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    1c0c219 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2024

  1. Merge branch 'main' into make-new-dot-signin-default-for-hybridapp 

    # Conflicts:
#	src/components/InitialURLContextProvider.tsx
#	src/libs/actions/Session/index.ts
    @war-in
    war-in committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    c848cfd View commit details
    Browse the repository at this point in the history

  2. improve openApp flow

    @war-in
    war-in committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    4170968 View commit details
    Browse the repository at this point in the history

  3. [HybridApp] Clean code (#143) 

    * Simplify HybridApp.ts

* Use early returns

* Rearrange HybridApp module

* Remove redundant keys

* Remove unused import
    @mateuuszzzzz
    mateuuszzzzz authored Nov 27, 2024
    Configuration menu
    Copy the full SHA
    50c3fed View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2024

  1. [HybridApp] Refactor SignInPage PR v2 (#144) 

    * Simplify HybridApp.ts

* Use early returns

* Rearrange HybridApp module

* Remove redundant keys

* Remove unused import

* Refactor remaining parts of code

* Do not init with useEffect

* Remove console.debug

* Reduce repeating code

* Remove unused import

* reset sign-in logic on sign out

---------

Co-authored-by: war-in <[email protected]>
    @mateuuszzzzz @war-in
    mateuuszzzzz and war-in authored Nov 28, 2024
    Configuration menu
    Copy the full SHA
    fb82b65 View commit details
    Browse the repository at this point in the history

  2. fix part of signup flow

    @war-in
    war-in committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    ecb93e2 View commit details
    Browse the repository at this point in the history

  3. [SignIn Page] New user flow (#145) 

    Co-authored-by: war-in <[email protected]>
    @war-in
    war-in and war-in authored Nov 28, 2024
    Configuration menu
    Copy the full SHA
    6f926fe View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into make-new-dot-signin-default-for-hybridapp

    @war-in
    war-in committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    f540207 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/make-new-dot-signin-default-for-… 

    …hybridapp' into make-new-dot-signin-default-for-hybridapp
    @war-in
    war-in committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    5aae4be View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2024

  1. fix isSingleNewDotEntry logic (travel feature)

    @war-in
    war-in committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    90c0954 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into make-new-dot-signin-default-for-hybridapp 

    # Conflicts:
#	src/libs/Navigation/AppNavigator/AuthScreens.tsx
#	src/libs/Navigation/AppNavigator/PublicScreens.tsx
    @war-in
    war-in committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    13180c2 View commit details
    Browse the repository at this point in the history