[TS migration] Migrate 'PDFView' component to TypeScript

[melvin-bot]

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path	Dependencies
src/components/PDFView/pdfViewPropTypes.js	3
src/components/PDFView/index.native.js	16
src/components/PDFView/index.js	19
src/components/PDFView/PDFPasswordForm.js	15
src/components/PDFView/PDFInfoMessage.js	10

[melvin-bot]

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot]

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

[roryabraham]

Looks like this component also need to be migrated to a functional component, not sure why it was missed.

Once we do that, we'll have no further uses of withKeyboardState, and we can greatly simplify that to remove:

• KeyboardStateContext
• KeyboardStateProvdider, KeyboardStateConsumer
• withKeyboardState

and consolidate that all into a single useKeyboardState hook.

Note: In #35270 we're considering adding https://kirillzyusko.github.io/react-native-keyboard-controller, in which case we can probably just use useKeyboardHandler hook directly.

[pac-guerreiro]

I'm Pedro Guerreiro from Callstack - expert contributor group. I’d like to work on this task!

[fabioh8010]

@pac-guerreiro let's migrate all files under src/components/PDFView folder

• constants.js
• index.js
• index.native.js
• PDFInfoMessage.js
• PDFPasswordForm.js
• pdfViewPropTypes.js
• WebPDFDocument.js
• WebPDFPageRenderer.js

[pac-guerreiro]

@fabioh8010 deal! 😄

[fabioh8010]

Any updates here @pac-guerreiro ?

[pac-guerreiro]

@fabioh8010 Draft PR is now open!

[melvin-bot]

Triggered auto assignment to @AndrewGable, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[CortneyOfstad]

PR has been merged and no payment needed as it was through CS. Closing!

[ishpaul777]

Hey @CortneyOfstad I reviewed the PR for this #39011, Can we please reopen for payment : )

[CortneyOfstad]

@ishpaul777 — just sent over an offer link via Upwork (job post is here) — let me know once you accept and I can get that paid for you ASAP. Thanks!

[CortneyOfstad]

Payment has been completed and this can be closed – thanks!