chore: add PR check to verify examples #259
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anssari1
force-pushed
the
nanssari/pr_checks
branch
2 times, most recently
from
06deaa9 to
5b518de
Compare
anssari1
force-pushed
the
nanssari/pr_checks
branch
from
fb79f5f to
5b518de
Compare
anssari1
changed the title
anssari1
force-pushed
the
nanssari/pr_checks
branch
from
5b518de to
1d6b8bf
Compare
mohnoor94
requested changes
Dec 17, 2024
There was a problem hiding this comment.
The current checkstyle configuration is causing excessive line wrapping, particularly for logging statements and method calls, which reduces code readability.
Suggestion: Let's increase the line length limit to 180 characters and potentially add exceptions for logging statements. This would maintain code cleanliness while avoiding unnecessary verbosity.
Thoughts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Situation
Examples have no quality checks
Task
Verify that updates to examples do not break compilation or linting rules
Action
Add a GH action to verify examples whenever a PR updates them
Testing
Results
Examples are verified as part of PR checks
Notes