chore: migrate to reusable ref docs gh action #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohnoor94
requested changes
Jan 15, 2025
Comment on lines
-5
to
-10
| inputs: | ||
| ref: | ||
| description: 'Choose the branch/tag/ref to deploy the reference documentation from' | ||
| required: true | ||
| default: 'main' | ||
| type: string |
There was a problem hiding this comment.
Let's keep this option available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Situation
At the moment of creating this pull request, we use the GitHub action
generate-reference-docs.yamlto generate docs. The action has a duplicate inrapid-java-sdk/.github/workflows/generate-docs-site.yml.Task
With the newly proposed reusable action in the
expediagroup-java-sdkrepository, specifically in the pr[933] chore: add reusable generate reference docs action, different product repositories can use a central GitHub action for generating and deploying reference docs.Delete the already existing
generate-reference-docs.yamlaction and consume the new action inexpediagroup-java-sdk.Action
Deleted the already existing action and modified it to consume the new action.
Testing
Results
We now consume the new centralized action.
Notes
Should not be merged before: