Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix identity API urls #129

Merged
merged 1 commit into from
Dec 15, 2024
Merged

fix: fix identity API urls #129

merged 1 commit into from
Dec 15, 2024

Conversation

Mohammad-Dwairi
Copy link
Contributor

Situation

We've been using identity URLs with a trailing slash, however, these URLs are not working at the moment and respond with 404 status.

Task

Fix the invalid URLs in the EndpointProvider class.

Testing

  1. Manually verified
  2. Existing tests are passing
  3. Sandbox examples are working as expected after the change.

@Mohammad-Dwairi Mohammad-Dwairi requested a review from a team as a code owner December 15, 2024 13:54
@Mohammad-Dwairi Mohammad-Dwairi merged commit eb9c67b into main Dec 15, 2024
1 check passed
@Mohammad-Dwairi Mohammad-Dwairi deleted the mdwairi/fix-auth-urls branch December 15, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohnoor94 mohnoor94 mohnoor94 approved these changes

@anssari1 anssari1 anssari1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mohammad-Dwairi @anssari1 @mohnoor94