fix: Limit the collaborator fields stored in Elasticsearch

Avoids issues with invalid users not matching the detected schema
ExpediaGroup · Feb 28, 2023 · 49b5ce1 · 49b5ce1
1 parent 676a594
commit 49b5ce1
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/packages/backend/src/lib/backends/github.sync.ts b/packages/backend/src/lib/backends/github.sync.ts
@@ -231,7 +231,17 @@ async function getInsightContributors(insight: IndexedInsight, yaml: InsightYaml
 async function getInsightCollaborators(insight: IndexedInsight): Promise<IndexedInsightCollaborator[]> {
   const insightService = Container.get(InsightService);
 
-  return await insightService.getCollaborators(insight as Insight);
+  const collaborators = await insightService.getCollaborators(insight as Insight);
+
+  // Return only the fields we need
+  return collaborators.map(({ permission, user }) => ({
+    permission,
+    user: {
+      userName: user.userName,
+      displayName: user.displayName,
+      email: user.email
+    }
+  }));
 }
 
 /**

diff --git a/packages/models/src/indexed/indexed-insight-collaborator.ts b/packages/models/src/indexed/indexed-insight-collaborator.ts
@@ -19,6 +19,6 @@ import type { RepositoryPermission } from '../repository-permission';
 import type { IndexedInsightUser } from './indexed-insight-user';
 
 export interface IndexedInsightCollaborator {
-  user: IndexedInsightUser;
+  user: Pick<IndexedInsightUser, 'userName' | 'displayName' | 'email'>;
   permission: RepositoryPermission;
 }