fix: Content Type case sensitivity #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffj254
approved these changes
Nov 15, 2023
jeffj254
approved these changes
Nov 15, 2023
danadajian
reviewed
Nov 15, 2023
| ...baseEvent, | ||
| headers: { | ||
| ...baseEvent.headers, | ||
| 'content-type': undefined, |
There was a problem hiding this comment.
We should probably remove the content-type key/value from the test since it wouldn't appear in a real headers object
There was a problem hiding this comment.
I originally was explicitly calling delete headers['content-type']; to remove this key/value but some investigation suggested this as a way of doing the same thing.
in TypeScript, setting a key to undefined using object spread syntax does effectively remove the key from the resulting object.
Accurate?
|
🎉 This PR is included in version 2.0.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
content-typeorContent-Typein the headerscontent-typeorContent-Typeheader keysThis change is necessary because GitHub very recently updated their webhook payloads and they've switched from 'content-type' to 'Content-Type'.