Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(approvals-satisfied): handle ownerless codeowner entries #530

Merged
merged 1 commit into from
Jan 18, 2024
Merged

fix(approvals-satisfied): handle ownerless codeowner entries #530

merged 1 commit into from
Jan 18, 2024

Conversation

danadajian
Copy link
Contributor

@danadajian danadajian commented Jan 18, 2024 •
edited
Loading

📝 Description

  • Fixes issue where an ownerless entry in codeowners was resulting in the approvals-satisfied helper always returning false.

@danadajian danadajian requested a review from a team as a code owner January 18, 2024 16:10
@danadajian danadajian merged commit 7498267 into main Jan 18, 2024
4 checks passed
@danadajian danadajian deleted the handle-ownerless-entries branch January 18, 2024 16:11
@danadajian
Copy link
Contributor Author

🎉 This PR is included in version 1.45.12 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@danadajian