fix(create-pr): clean up return_full_payload input (#419)

ExpediaGroup · Aug 30, 2023 · e579caa · e579caa
1 parent 0439ac2
commit e579caa
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 23 deletions.
diff --git a/dist/150.index.js b/dist/150.index.js
diff --git a/dist/150.index.js.map b/dist/150.index.js.map
diff --git a/src/helpers/create-pr.ts b/src/helpers/create-pr.ts
@@ -11,7 +11,6 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
-import * as core from '@actions/core';
 import { HelperInputs } from '../types/generated';
 import { context } from '@actions/github';
 import { octokit } from '../octokit';
@@ -25,7 +24,7 @@ export class CreatePR extends HelperInputs {
   return_full_payload?: string;
 }
 
-export const createPr = async ({ title, body, head = context.ref.replace('refs/heads/', ''), base }: CreatePR) => {
+export const createPr = async ({ title, body, head = context.ref.replace('refs/heads/', ''), base, return_full_payload }: CreatePR) => {
   const pr_base = base || (await getDefaultBranch());
   await updateHeadWithBaseBranch(pr_base, head);
   const { data } = await octokit.pulls.create({
@@ -36,8 +35,7 @@ export const createPr = async ({ title, body, head = context.ref.replace('refs/h
     maintainer_can_modify: true,
     ...context.repo
   });
-  const return_full_payload = core.getBooleanInput('return_full_payload');
-  return return_full_payload ? data : data.number;
+  return return_full_payload === 'true' ? data : data.number;
 };
 
 const updateHeadWithBaseBranch = (base: string, head: string) =>

diff --git a/test/helpers/create-pr.test.ts b/test/helpers/create-pr.test.ts
@@ -11,7 +11,6 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
-import * as core from '@actions/core';
 import { Mocktokit } from '../types';
 import { context } from '@actions/github';
 import { createPr } from '../../src/helpers/create-pr';
@@ -90,7 +89,6 @@ describe('createPr', () => {
   });
 
   it('should return the full response object', async () => {
-    (core.getBooleanInput as jest.Mock).mockReturnValue(true);
     const result = await createPr({
       title,
       body,