fix(assign-pr-reviewers): stop returning response from axios (#338)

* fix(assign-pr-reviewers): stop returning response from axios * stop returning inside notify-user.ts
ExpediaGroup · Feb 21, 2023 · ca4d3b1 · ca4d3b1
1 parent 2f61b0f
commit ca4d3b1
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 7 deletions.
diff --git a/dist/153.index.js b/dist/153.index.js
diff --git a/dist/153.index.js.map b/dist/153.index.js.map
diff --git a/dist/676.index.js b/dist/676.index.js
diff --git a/dist/676.index.js.map b/dist/676.index.js.map
diff --git a/src/helpers/assign-pr-reviewers.ts b/src/helpers/assign-pr-reviewers.ts
@@ -61,7 +61,7 @@ export const assignPrReviewers = async ({
   });
 
   if (slack_webhook_url) {
-    return map(
+    await map(
       assignees,
       async assignee =>
         notifyUser({

diff --git a/src/utils/notify-user.ts b/src/utils/notify-user.ts
@@ -36,7 +36,7 @@ export const notifyUser = async ({ login, pull_number, slack_webhook_url }: Noti
   } = await octokit.pulls.get({ pull_number, ...context.repo });
 
   try {
-    return axios.post(slack_webhook_url, {
+    await axios.post(slack_webhook_url, {
       assignee: email,
       title,
       html_url,