chore: remove usages of it.each in unit tests (#169)

ExpediaGroup · Mar 30, 2022 · c1f637b · c1f637b
1 parent f9709ce
commit c1f637b
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 6 deletions.
diff --git a/test/helpers/assign-pr-reviewers.test.ts b/test/helpers/assign-pr-reviewers.test.ts
@@ -109,9 +109,9 @@ describe('assignPrReviewer', () => {
       await assignPrReviewers({ teams, slack_webhook_url });
     });
 
-    it.each(['assignee'])('should call notifyUser with correct params', assignee => {
+    it('should call notifyUser with correct params', () => {
       expect(notifyUser).toHaveBeenCalledWith({
-        login: assignee,
+        login: 'assignee',
         pull_number,
         slack_webhook_url
       });

diff --git a/test/helpers/notify-pipeline-complete.test.ts b/test/helpers/notify-pipeline-complete.test.ts
@@ -49,9 +49,23 @@ describe('setOpenPullRequestStatus', () => {
     });
   });
 
-  it.each(['sha 1', 'sha 2', 'sha 3'])('should call createCommitStatus with correct params', sha => {
+  it('should call createCommitStatus with correct params', () => {
     expect(octokit.repos.createCommitStatus).toHaveBeenCalledWith({
-      sha,
+      sha: 'sha 1',
+      context: DEFAULT_PIPELINE_STATUS,
+      state: 'success',
+      description,
+      ...context.repo
+    });
+    expect(octokit.repos.createCommitStatus).toHaveBeenCalledWith({
+      sha: 'sha 2',
+      context: DEFAULT_PIPELINE_STATUS,
+      state: 'success',
+      description,
+      ...context.repo
+    });
+    expect(octokit.repos.createCommitStatus).toHaveBeenCalledWith({
+      sha: 'sha 3',
       context: DEFAULT_PIPELINE_STATUS,
       state: 'success',
       description,

diff --git a/test/helpers/set-commit-status.test.ts b/test/helpers/set-commit-status.test.ts
@@ -65,10 +65,18 @@ describe('setCommitStatus', () => {
       });
     });
 
-    it.each(['context1', 'context2'])('should call createCommitStatus with correct params', context => {
+    it('should call createCommitStatus with correct params', () => {
       expect(octokit.repos.createCommitStatus).toHaveBeenCalledWith({
         sha,
-        context,
+        context: 'context1',
+        state,
+        description,
+        target_url,
+        ...githubContext.repo
+      });
+      expect(octokit.repos.createCommitStatus).toHaveBeenCalledWith({
+        sha,
+        context: 'context2',
         state,
         description,
         target_url,