feat(approvals-satisfied): only comment when body present (#636)

* feat(approvals-satisfied): only comment when there is a body * fix * test name
ExpediaGroup · Jul 11, 2024 · a69b425 · a69b425
1 parent f0a4649
commit a69b425
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 23 deletions.
diff --git a/dist/431.index.js b/dist/431.index.js
diff --git a/dist/431.index.js.map b/dist/431.index.js.map
diff --git a/dist/676.index.js b/dist/676.index.js
diff --git a/dist/676.index.js.map b/dist/676.index.js.map
diff --git a/src/helpers/approvals-satisfied.ts b/src/helpers/approvals-satisfied.ts
@@ -101,11 +101,11 @@ export const approvalsSatisfied = async ({
 
     if (body) {
       logs.unshift(body + '\n');
-    }
 
-    await createPrComment({
-      body: logs.join('\n')
-    });
+      await createPrComment({
+        body: logs.join('\n')
+      });
+    }
   }
 
   core.info(logs.join('\n'));

diff --git a/test/helpers/approvals-satisfied.test.ts b/test/helpers/approvals-satisfied.test.ts
@@ -579,7 +579,7 @@ describe('approvalsSatisfied', () => {
   });
 
   describe('pr comments', () => {
-    it('should make pr comment when approvals not satisfied', async () => {
+    it('should not make pr comment when approvals not satisfied and no body', async () => {
       mockPagination({
         data: [
           {
@@ -592,16 +592,7 @@ describe('approvalsSatisfied', () => {
         users: '@user1,@user2',
         pull_number: '12345'
       });
-      expect(octokit.issues.createComment).toHaveBeenCalledWith(
-        expect.objectContaining({
-          body: `Required approvals not satisfied:
-
-PR already approved by: user3
-Required code owners: @user1,@user2
-Current number of approvals satisfied for @user1,@user2: 0
-Number of required reviews: 1`
-        })
-      );
+      expect(octokit.issues.createComment).not.toHaveBeenCalled();
     });
 
     it('should make pr comment including approvalsNotMetMessage when it is passed and approvals not satisfied', async () => {