Skip to content

Commit

Permalink
fix(check-merge-safety): simplify check merge safety helper (#298)
Browse files Browse the repository at this point in the history
* fix(check-merge-safety): simplify check

* improve tests

* update readme

* update docs

* fix code and tests

* fix tests

* clarify

* add another test for globs

* add success log

* improve error logging

* clean up

* add space

* simplify

* fix log
  • Loading branch information
danadajian authored Nov 30, 2022
1 parent 6a7220d commit 281624c
Show file tree
Hide file tree
Showing 5 changed files with 109 additions and 119 deletions.
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -90,11 +90,11 @@ This workflow should be run on both `pull_request` and `push` events:

The following parameters can be used for additional control over when it is safe to merge a PR:

* `paths` defines file paths to all of a repo's co-dependent projects which could be affected by a PR
* `paths`: These are the file paths to all of a repo's projects (usually paths to standalone packages)
* This is useful for monorepos with multiple projects which are decoupled from each other but are affected by global dependencies.
* `override_filter_paths` defines file paths that, if out of date on a PR, will prevent merge no matter what files the PR is changing
* `override_filter_paths`: These are the file paths that, if out of date on a PR, will prevent merge no matter what files the PR is changing
* example: `override_filter_paths: package.json,package-lock.json`
* `override_filter_globs` defines glob patterns for `override_filter_paths`
* `override_filter_globs`: These are glob patterns for `override_filter_paths`

### [create-pr](.github/workflows/create-pr.yml)
* Opens a pull request
Expand Down
31 changes: 21 additions & 10 deletions dist/180.index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 281624c

Please sign in to comment.