Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Expose Redis connection pool metrics using prometheus #158

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

EXPEbdodla
Copy link
Collaborator

@EXPEbdodla EXPEbdodla commented Nov 12, 2024

What this PR does / why we need it:

  1. Redis connection pool metrics are exposed using /metrics endpoint. We can export them if necessary. https://github.com/redis/go-redis/tree/master/extra/redisprometheus
  2. Redis Go version v9.6.1 behaving odd. Routing the traffic to Master nodes once every ~4 hours for E4B traffic. Seems like a bug in the version. So upgrading to latest version where some connection related bugs are fixed.

Which issue(s) this PR fixes:

feat: Expose Redis connection pool metrics
fix: Update go-redis dependency to v9.7.0

Misc

@EXPEbdodla EXPEbdodla changed the title chore: Update go-redis dependency to v9.7.0 feat: Expose Redis connection pool metrics using prometheus Nov 13, 2024
@EXPEbdodla EXPEbdodla merged commit 61c8b88 into master Nov 14, 2024
24 checks passed
@EXPEbdodla EXPEbdodla deleted the upgrade_redis_go branch November 14, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants