fix: disabled data deletion when feature view is deleted (#13)

* disabled data deletion when feature view is deleted --------- Co-authored-by: Bhargav Dodla <[email protected]>
ExpediaGroup · Aug 3, 2023 · b541fa7 · b541fa7
1 parent 84a8ea3
commit b541fa7
Show file tree

Hide file tree

Showing 6 changed files with 24 additions and 14 deletions.
diff --git a/sdk/python/feast/__init__.py b/sdk/python/feast/__init__.py
@@ -8,6 +8,9 @@
 from feast.infra.offline_stores.contrib.athena_offline_store.athena_source import (
     AthenaSource,
 )
+from feast.infra.offline_stores.contrib.spark_offline_store.spark_source import (
+    SparkSource,
+)
 from feast.infra.offline_stores.file_source import FileSource
 from feast.infra.offline_stores.redshift_source import RedshiftSource
 from feast.infra.offline_stores.snowflake_source import SnowflakeSource
@@ -54,4 +57,5 @@
     "PushSource",
     "RequestSource",
     "AthenaSource",
+    "SparkSource",
 ]
diff --git a/sdk/python/feast/feature_view.py b/sdk/python/feast/feature_view.py
@@ -40,7 +40,7 @@
 from feast.usage import log_exceptions
 from feast.value_type import ValueType
 
-warnings.simplefilter("once", DeprecationWarning)
+warnings.simplefilter("ignore", DeprecationWarning)
 
 # DUMMY_ENTITY is a placeholder entity used in entityless FeatureViews
 DUMMY_ENTITY_ID = "__dummy_id"

diff --git a/sdk/python/feast/infra/aws.py b/sdk/python/feast/infra/aws.py
@@ -53,16 +53,19 @@ def update_infra(
         entities_to_keep: Sequence[Entity],
         partial: bool,
     ):
+        # TODO: Temporarily disabling the capability of Deleting data
+        # from online stores when a Feature View is deleted.
+
         # Call update only if there is an online store
-        if self.online_store:
-            self.online_store.update(
-                config=self.repo_config,
-                tables_to_delete=tables_to_delete,
-                tables_to_keep=tables_to_keep,
-                entities_to_keep=entities_to_keep,
-                entities_to_delete=entities_to_delete,
-                partial=partial,
-            )
+        # if self.online_store:
+        #     self.online_store.update(
+        #         config=self.repo_config,
+        #         tables_to_delete=tables_to_delete,
+        #         tables_to_keep=tables_to_keep,
+        #         entities_to_keep=entities_to_keep,
+        #         entities_to_delete=entities_to_delete,
+        #         partial=partial,
+        #     )
 
         if self.repo_config.feature_server and self.repo_config.feature_server.enabled:
             warnings.warn(

diff --git a/sdk/python/feast/infra/offline_stores/contrib/spark_offline_store/spark.py b/sdk/python/feast/infra/offline_stores/contrib/spark_offline_store/spark.py
@@ -37,8 +37,8 @@
 from feast.type_map import spark_schema_to_np_dtypes
 from feast.usage import log_exceptions_and_usage
 
-# Make sure spark warning doesn't raise more than once.
-warnings.simplefilter("once", RuntimeWarning)
+# Make sure spark warning are ignored
+warnings.simplefilter("ignore", RuntimeWarning)
 
 
 class SparkOfflineStoreConfig(FeastConfigBaseModel):

diff --git a/sdk/python/feast/infra/offline_stores/contrib/spark_offline_store/spark_source.py b/sdk/python/feast/infra/offline_stores/contrib/spark_offline_store/spark_source.py
@@ -21,6 +21,9 @@
 
 logger = logging.getLogger(__name__)
 
+# Make sure spark warning are ignored
+warnings.simplefilter("ignore", RuntimeWarning)
+
 
 class SparkSourceFormat(Enum):
     csv = "csv"

diff --git a/sdk/python/tests/unit/test_sql_registry.py b/sdk/python/tests/unit/test_sql_registry.py
@@ -90,8 +90,8 @@ def mysql_registry():
 
     container.start()
 
-    # The log string uses '8.0.*' since the version might be changed as new Docker images are pushed.
-    log_string_to_wait_for = "/usr/sbin/mysqld: ready for connections. Version: '8.0.*'  socket: '/var/run/mysqld/mysqld.sock'  port: 3306"
+    # The log string uses '8.1.*' since the version might be changed as new Docker images are pushed.
+    log_string_to_wait_for = "/usr/sbin/mysqld: ready for connections. Version: '8.1.*'  socket: '/var/run/mysqld/mysqld.sock'  port: 3306"
     waited = wait_for_logs(
         container=container,
         predicate=log_string_to_wait_for,