feedback

go/internal/feast/featurestore.go

@@ -56,12 +56,11 @@ func NewFeatureStore(config *registry.RepoConfig, callback transformation.Transf
 		return nil, err
 	}
 
-	if config.GoTransformationsEndpoint == "" && config.GoTransformationsServer {
-		return nil, errors.New("transformations server endpoint is missing")
-	}
-
 	var transformationService *transformation.GrpcTransformationService = nil
-	if config.GoTransformationsEndpoint != "" {
+	if config.GoTransformationsServer {
+		if config.GoTransformationsEndpoint == "" {
+			return nil, errors.New("Transformations server endpoint is missing. Update featue_store.yaml with go_transformations_endpint configuration")
+		}
 		transformationService, _ = transformation.NewGrpcTransformationService(config, config.GoTransformationsEndpoint)
 	}
 

go/internal/feast/registry/repoconfig.go

@@ -32,9 +32,10 @@ type RepoConfig struct {
 	RepoPath string `json:"repo_path"`
 	// EntityKeySerializationVersion
 	EntityKeySerializationVersion int64 `json:"entity_key_serialization_version"`
-	// If false, use gopy bindings to calculate ODFV transformations
+	// If false, use gopy bindings to calculate ODFV transformations.
+	// "True" value required for Go feature server to serve ODFVs with stability and at scale.
 	GoTransformationsServer bool `json:"go_transformations_server"`
-	// Transformation server base endpoint
+	// Transformation server base endpoint.
 	GoTransformationsEndpoint string `json:"go_transformations_endpoint"`
 }