Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration test enhancements #10

Merged
merged 8 commits into from
Sep 30, 2024
Merged

Integration test enhancements #10

merged 8 commits into from
Sep 30, 2024

Conversation

witomlin
Copy link
Contributor

@witomlin witomlin commented Sep 30, 2024 •
edited
Loading

  • Allows multiple versions of Kube to be tested during integration tests.
  • Adds integration tests for Kube 1.28, 1.29, 1.30 and 1.31.
  • All currently certified versions are tested during execution of GHA integration tests.
  • Implemented workaround for container statuses not being updated in a timely fashion, leading to very long integration test execution times (see [FG:InPlacePodVerticalScaling] Pod Resize - long delay in updating apiPodStatus.Resources kubernetes/kubernetes#112264).
  • Refactored handling of supplied configuration when running integration tests.
  • Refactored integration test logging to use t.Log() to properly differentiate between the logs of different tests.
    • Logging now also includes timestamp and test name.
  • Pulled out all integration test static configuration into a new file (consts.go).
  • Docs updated as necessary.

nikos912000
nikos912000 reviewed Sep 30, 2024
View reviewed changes
README.md
Comment on lines +524 to +528
| `REUSE_CLUSTER` | `false` | Whether to reuse an existing CSA kind cluster (if it already exists). `KUBE_VERSION` has no effect if an existing cluster is reused. |
| `INSTALL_METRICS_SERVER` | `false` | Whether to install metrics-server. |
| `KEEP_CSA` | `false` | Whether to keep the CSA installation after tests finish. |
| `KEEP_CLUSTER` | `false` | Whether to keep the CSA kind cluster after tests finish. |
| `DELETE_NS_AFTER_TEST` | `true` | Whether to delete namespaces created by tests after they conclude. |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid feature (parameter) creep we could avoid exposing these parameters. The default values are expected to provide a clean execution.

@witomlin witomlin merged commit 4544e9a into main Sep 30, 2024
6 checks passed
@witomlin witomlin deleted the int-tests-enhancements branch September 30, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikos912000 nikos912000 nikos912000 approved these changes

Assignees

@nikos912000 nikos912000

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@witomlin @nikos912000