added variables to readme

ExpediaGroup · Nov 30, 2023 · 8216dac · 8216dac
1 parent 4d41e4b
commit 8216dac
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/README.md b/README.md
@@ -54,6 +54,9 @@ For more information please refer to the main [Apiary](https://github.com/Expedi
 | root_vol_type                      | Waggle Dance EC2 root volume type.                                                                                                                                                                                                                                                                          | string |     `gp2`      | no |
 | root_vol_size                      | Waggle Dance EC2 root volume size.                                                                                                                                                                                                                                                                          | string |      `10`      | no |
 |enable_query_functions_across_all_metastores | This controls the thrift call for `get_all_functions`. It is generally used to initialize a client and get built-in functions and registered UDF's from a metastore. Setting this to `false` is more performant as WD then only gets the functions from the `primary` metastore. However, setting this to `true` will collate results by calling `get_all_functions` from all configured metastores. This could be potentially slow if some of the metastores are slow to respond. If all the metastores configured are of the same version and no additional UDF's are installed, then WD gets the same functions back so it's not very useful to call this across metastores. For backwards compatibility, this property can be set to `true`. Further read: https://github.com/ExpediaGroup/waggle-dance#server | bool | false | no |
+| tcp_keepalive_time                 | Sets net.ipv4.tcp_keepalive_time (seconds), currently only supported in ECS.                                                                                                                                                                                                                                | number |     `200`      | no |
+| tcp_keepalive_intvl                | Sets net.ipv4.tcp_keepalive_intvl (seconds), currently only supported in ECS.                                                                                                                                                                                                                               | number |     `30`       | no |
+| tcp_keepalive_probes               | Sets net.ipv4.tcp_keepalive_probes (seconds), currently only supported in ECS.                                                                                                                                                                                                                              | number |      `2`       | no |
 
 ## Usage
 

diff --git a/variables.tf b/variables.tf
@@ -361,19 +361,19 @@ variable "datadog_metrics_enabled" {
 }
 
 variable "tcp_keepalive_time" {
-  description = "sets net.ipv4.tcp_keepalive_time (seconds), currently only supported in ECS. "
-  type        = string
+  description = "Sets net.ipv4.tcp_keepalive_time (seconds), currently only supported in ECS."
+  type        = number
   default     = 200
 }
 
 variable "tcp_keepalive_intvl" {
-  description = "sets net.ipv4.tcp_keepalive_intvl (seconds), currently only supported in ECS. "
-  type        = string
+  description = "Sets net.ipv4.tcp_keepalive_intvl (seconds), currently only supported in ECS."
+  type        = number
   default     = 30
 }
 
 variable "tcp_keepalive_probes" {
-  description = "sets net.ipv4.tcp_keepalive_probes (number), currently only supported in ECS. "
-  type        = string
+  description = "Sets net.ipv4.tcp_keepalive_probes (number), currently only supported in ECS."
+  type        = number
   default     = 2
 }