fix: type support for props supplied in .attrs()
#25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparten11740
force-pushed
the
sparten11740/feat/typesupport-for-attrs
branch
from
6bfa09e to
518db3a
Compare
sparten11740
commented
Oct 23, 2024
Comment on lines
-33
to
-42
| type ComponentFactory<P extends object, S extends object> = <SP extends object>( | ||
| componentStyle: ComponentStyle<P, SP, S> | ||
| ) => StyledComponent<P & SP, S> | (() => StyledComponent<P, S>); | ||
|
|
||
| export interface StyledFunction{ | ||
| <P extends object, S extends object>( | ||
| Comp: React.ComponentType<P>, | ||
| config?: Config<P> | ||
| ): ComponentFactory<P, S>; | ||
| } |
There was a problem hiding this comment.
removed these as they were unused
sparten11740
changed the title
.attrs().attrs()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes properties passed into
attrs()optional on the resulting component.E.g. a component
LinearGradientthat requires thecolorsprop, can be wrapped as follows:They won't require consumers to pass the required
colorsprop